Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding fuller implementation of ParameterMetadata #114

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Adding fuller implementation of ParameterMetadata #114

wants to merge 6 commits into from

Conversation

eramitmittal
Copy link

@eramitmittal eramitmittal commented Dec 20, 2024 •
edited
Loading

Fixes #121
On the lines of pre-existing implementation of corresponding methods for columns in ResultSetMetaData, adding ParameterMetadata implementations for

  1. isSigned
  2. getPrecision
  3. getScale
  4. getParameterType
  5. getParameterTypeName
  6. getParameterClassName

@eramitmittal
Copy link
Author

hi, any update on this?

@eramitmittal
Copy link
Author

hi @Mause, can you please review and merge?

@eramitmittal
Copy link
Author

eramitmittal commented Jan 9, 2025 •
edited
Loading

The format_check failure is strange because the failing file 'DuckDBDatabaseMetaData.java' is not even part of my commit

@eramitmittal
Copy link
Author

@Mause can this be merged please if there are no issues?

@eramitmittal
Copy link
Author

Any update on this?

@hannes
Copy link
Member

hannes commented Jan 31, 2025

thanks!

staticlibs added a commit to staticlibs/duckdb-java that referenced this pull request Mar 31, 2025
@staticlibs
Implement ParameterMetadata
3dcfe85 
This PR brings in the change that was contributed earlier by
`eramitmittal` in duckdb#114 but was not merged. That change is rebased onto
the latest `main`with minimal adjustetments.

Testing: in addition to the `DECIMAL` test from original PR more tests
are added to cover all other column types.

Fixes: duckdb#121

Co-authored-by: eramitmittal
@staticlibs staticlibs mentioned this pull request Mar 31, 2025
Open
@staticlibs
Copy link
Contributor

@eramitmittal

Thanks for this implementation! I took the liberty to re-submit the updated version of this PR in #181 (referencing you in the commit message). Please let me know, if instead you would like to update this PR yourself (I then will close #181).

@eramitmittal
Copy link
Author

@eramitmittal

Thanks for this implementation! I took the liberty to re-submit the updated version of this PR in #181 (referencing you in the commit message). Please let me know, if instead you would like to update this PR yourself (I then will close #181).

hi, this is fine. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ParameterMetadata is only partially implemented
3 participants
@eramitmittal @hannes @staticlibs