Fix #233 Add limit pushdown to attached queries #313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements limit pushdown #233
Gets applied on all postgres attached queries, if preferred can be applied only when an option like experimental pushdown is set, however in this implementation triggers the same as the mysql_scanner limit pushdown implementation.
This change greatly improves performance for queries that include a
LIMIT
.What it does:
select bar from attached_pg.foo limit 1;
Previously
COPY (SELECT "bar" FROM "attached_pg"."foo" ) TO STDOUT (FORMAT "binary");
Now
COPY (SELECT "bar" FROM "attached_pg"."foo" LIMIT 1) TO STDOUT (FORMAT "binary");
I am not sure how a specific test for this would look like as I am not sure there is a way to verify generated SQL. A generic limit test was added.
Works for
LIMIT
andOFFSET
. If anORDER_BY
is present it will not be added.