Skip to content

Conversation

ak2k
Copy link
Contributor

@ak2k ak2k commented Jun 27, 2025

There appears to be an issue where SQLiteInsert uses the raw plan instead of the type-casted plan. The code calls AddCastToSQLiteTypes to create inner_plan but then uses the original plan:

  auto &inner_plan = AddCastToSQLiteTypes(context, planner, *plan);
  auto &insert = planner.Make<SQLiteInsert>(op, op.table, op.column_index_map);
  insert.children.push_back(*plan);  // Should this be inner_plan?

@ak2k ak2k closed this Jul 16, 2025
@ak2k ak2k force-pushed the fix/sqlite-insert-cast branch from 56a66f2 to 801922e Compare July 16, 2025 23:35
@ak2k ak2k reopened this Jul 16, 2025
@Mytherin Mytherin merged commit 833e105 into duckdb:main Sep 2, 2025
24 of 28 checks passed
@Mytherin
Copy link
Contributor

Mytherin commented Sep 2, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants