Support parameters in sqlite_query #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds new optional `params` argument to `sqlite_query` function
that allows to pass query parameters to an underlying SQLite prepared
statement.
Parameters are specified as a `STRUCT`, that can be created inline using
`row()` function:
```sql
SELECT * from sqlite_query(sakila, 'SELECT ? || ? a', params=row('foo', 'bar'))
----
foobar
```
When the whole DuckDB SQL statement, that contains `sqlite_query()`
function, is used with `PREPARE` + `EXECUTE` (for example, from Python
or Java client), then the external client-provided parameters will be
forwarded to SQLite:
```sql
PREPARE p1 as SELECT * from sqlite_query(sakila, 'SELECT ? || ? a', params=row(?, ?))
EXECUTE p1('foo', 'bar')
----
foobar
EXECUTE p1('baz', 'boo')
----
bazboo
DEALLOCATE p1
```
The following parameter types are supported: `BIGINT`, `DOUBLE`, `BLOB`,
`VARCHAR`.
Only positional parameters are supported - `STRUCT` field names are
ignored.
Testing: existing `sqlite_query` test is updated with parameters checks.
staticlibs
force-pushed
the
query_params
branch
from
9a14296 to
c4efd66
Compare
|
Merging this for API parity with duckdb/duckdb-mysql#158. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new optional
paramsargument tosqlite_queryfunction that allows to pass query parameters to an underlying SQLite prepared statement.Parameters are specified as a
STRUCT, that can be created inline usingrow()function:When the whole DuckDB SQL statement, that contains
sqlite_query()function, is used withPREPARE+EXECUTE(for example, from Python or Java client), then the external client-provided parameters will be forwarded to SQLite:The following parameter types are supported:
BIGINT,DOUBLE,BLOB,VARCHAR.Only positional parameters are supported -
STRUCTfield names are ignored.Testing: existing
sqlite_querytest is updated with parameters checks.