fix: opfs support issues #1973
Merged
fix: opfs support issues #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update opfs tests change dropFiles args
# Conflicts: # packages/duckdb-wasm/test/opfs.test.ts
# Conflicts: # packages/duckdb-wasm/src/parallel/async_bindings.ts
# Conflicts: # packages/duckdb-wasm/src/parallel/async_bindings.ts
…_support_issues # Conflicts: # lib/CMakeLists.txt # packages/duckdb-wasm/src/bindings/bindings_base.ts # packages/duckdb-wasm/test/opfs.test.ts
e1arikawa
force-pushed
the
fix_opfs_support_issues
branch
from
05492ac to
84f31b8
Compare
e1arikawa
force-pushed
the
fix_opfs_support_issues
branch
from
4dc135a to
aa3735f
Compare
# Conflicts: # patches/duckdb/no_httpfs.patch
Collaborator
|
Thanks a ton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes:
OPFS:// Support
To enable OPFS:// support, not only was the feature added, but modifications to dropFiles (item 2) were necessary, and several tests were updated (item 3).
DropFiles Enhancement
Updated
dropFilesto support handling multiple files.#1945
Test Updates
Modified test cases accordingly to support the changes in items 1 and 2.
#1968
Minor Modifications:
Indentation Fixes
Corrected code indentation for improved readability.
Patch Removal for Duckdb
Removed
binary_executor.patchas Duckdb now supportsDUCKDB_SMALLER_BINARY.