Add implicit % to bridge TABLESAMPLE syntax#559
Merged
Conversation
nbiscaro
force-pushed
the
bridge-tablesample
branch
from
18aed00 to
616fbdc
Compare
nbiscaro
changed the title
JelteF
reviewed
Jan 27, 2025
JelteF
requested changes
Jan 27, 2025
Collaborator
JelteF
left a comment
JelteF
left a comment
There was a problem hiding this comment.
Thank you for the PR! This needs some tests though.
nbiscaro
force-pushed
the
bridge-tablesample
branch
2 times, most recently
from
76966b8 to
e216177
Compare
JelteF
requested changes
Feb 26, 2025
Collaborator
JelteF
left a comment
JelteF
left a comment
There was a problem hiding this comment.
Sorry for the delayed response. This is a very useful feature. I left two small comments, but other than that I think this is good to merge.
Collaborator
|
@nbiscaro do you still intend to address these comments? |
Contributor
Author
Yes! Will get to this within the next 48 hours. |
Collaborator
|
@nbiscaro any progress? |
nbiscaro
force-pushed
the
bridge-tablesample
branch
3 times, most recently
from
5218f5d to
048e885
Compare
JelteF
approved these changes
Mar 22, 2025
JelteF
approved these changes
Apr 15, 2025
Y--
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bridge syntax differences in
TABLESAMPLEby adding implicit%.Fixes #558
Fixes #429