Set up support for AppTP blocklist experiments#5864
Merged
GuiltyDolphin merged 25 commits intodevelopfrom Apr 23, 2025
Merged
Conversation
aitorvs
reviewed
Apr 4, 2025
...g-protection/vpn-impl/src/main/java/com/duckduckgo/mobile/android/vpn/blocklist/Blocklist.kt
Outdated
Show resolved
Hide resolved
3761959 to
971b063
Compare
aitorvs
reviewed
Apr 5, 2025
...t/java/com/duckduckgo/mobile/android/vpn/blocklist/AppTPBlockListInterceptorApiPluginTest.kt
Outdated
Show resolved
Hide resolved
aitorvs
reviewed
Apr 5, 2025
...t/java/com/duckduckgo/mobile/android/vpn/blocklist/AppTPBlockListInterceptorApiPluginTest.kt
Outdated
Show resolved
Hide resolved
aitorvs
reviewed
Apr 5, 2025
...tion/vpn-impl/src/main/java/com/duckduckgo/mobile/android/vpn/feature/AppTpRemoteFeatures.kt
Outdated
Show resolved
Hide resolved
GuiltyDolphin
commented
Apr 10, 2025
...t/java/com/duckduckgo/mobile/android/vpn/blocklist/AppTPBlockListInterceptorApiPluginTest.kt
Outdated
Show resolved
Hide resolved
...ection/vpn-impl/src/main/java/com/duckduckgo/mobile/android/vpn/pixels/DeviceShieldPixels.kt
Outdated
Show resolved
Hide resolved
aitorvs
reviewed
Apr 15, 2025
...tion/vpn-impl/src/main/java/com/duckduckgo/mobile/android/vpn/feature/AppTpRemoteFeatures.kt
Outdated
Show resolved
Hide resolved
...on/vpn-impl/src/main/java/com/duckduckgo/mobile/android/vpn/cohort/CohortPixelInterceptor.kt
Outdated
Show resolved
Hide resolved
marcosholgado
requested changes
Apr 23, 2025
Contributor
marcosholgado
left a comment
There was a problem hiding this comment.
Just a minor change to use a public API rather than a private one.
.../main/java/com/duckduckgo/mobile/android/vpn/blocklist/AppTPBlockListInterceptorApiPlugin.kt
Outdated
Show resolved
Hide resolved
e475ff2 to
b998987
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1209746219895489/f
Description
Adds support for AppTP TDS A/B experiments via privacy configuration.
Steps to test this PR
Automated tests:
AppTPBlockListInterceptorApiPluginTest.ktfileManual check:
featuresforappTrackerProtectioninandroid-override.json:AppTP, you should see the URL being rewritten (similar to screenshot)atpTdsExperiment002, change control value to 0 and treatment to 1. Change state todisabledforatpTdsExperiment001. Verify you're seeing the URL rewritten as treatment & experiment as 002 in the logs (after repeating steps 2-4)