Skip to content

Comments

Set up support for AppTP blocklist experiments#5864

Merged
GuiltyDolphin merged 25 commits intodevelopfrom
gd-apptp-blocklist-experiment-feature
Apr 23, 2025
Merged

Set up support for AppTP blocklist experiments#5864
GuiltyDolphin merged 25 commits intodevelopfrom
gd-apptp-blocklist-experiment-feature

Conversation

@GuiltyDolphin
Copy link
Member

@GuiltyDolphin GuiltyDolphin commented Apr 4, 2025

Task/Issue URL: https://app.asana.com/0/72649045549333/1209746219895489/f

Description

Adds support for AppTP TDS A/B experiments via privacy configuration.

Steps to test this PR

Automated tests:

  • run the AppTPBlockListInterceptorApiPluginTest.kt file

Manual check:

  1. Using the remote debugger, add in the features for appTrackerProtection in android-override.json:
                "atpTdsExperiment001": {
                    "state": "enabled",
                    "minSupportedVersion": 52240000,
                    "rollout": {
                        "steps": [
                            {
                                "percent": 100
                            }
                        ]
                    },
                    "settings": {
                        "controlUrl": "experiment/android-tds-a0.json",
                        "treatmentUrl": "experiment/android-tds-a1.json"
                    },
                    "cohorts": [
                        {
                            "name": "control",
                            "weight": 1
                        },
                        {
                            "name": "treatment",
                            "weight": 0
                        }
                    ]
                },
  1. Reload the config
  2. in AppTP dev settings, force load the blocklist then leave the settings page
  3. in logcat, filter to AppTP, you should see the URL being rewritten (similar to screenshot)
  4. copy the entry to atpTdsExperiment002, change control value to 0 and treatment to 1. Change state to disabled for atpTdsExperiment001. Verify you're seeing the URL rewritten as treatment & experiment as 002 in the logs (after repeating steps 2-4)

image

@GuiltyDolphin GuiltyDolphin force-pushed the gd-apptp-blocklist-experiment-feature branch from 3761959 to 971b063 Compare April 4, 2025 15:34
@GuiltyDolphin GuiltyDolphin requested a review from aitorvs April 11, 2025 11:12
@GuiltyDolphin GuiltyDolphin marked this pull request as ready for review April 11, 2025 16:29
Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change to use a public API rather than a private one.

Copy link
Contributor

@marcosholgado marcosholgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuiltyDolphin GuiltyDolphin force-pushed the gd-apptp-blocklist-experiment-feature branch from e475ff2 to b998987 Compare April 23, 2025 15:18
@GuiltyDolphin GuiltyDolphin enabled auto-merge (squash) April 23, 2025 15:19
@GuiltyDolphin GuiltyDolphin merged commit faec1c2 into develop Apr 23, 2025
5 checks passed
@GuiltyDolphin GuiltyDolphin deleted the gd-apptp-blocklist-experiment-feature branch April 23, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants