Merged
Conversation
267a73e to
0a4c845
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to preserve IndexedDB entries for fireproofed sites by excluding specific IndexedDB folders from deletion. Key changes include:
- Introduction of the DuckDuckGoIndexedDBManager to handle IndexedDB folder exclusion.
- Updates to tests in IndexedDBManagerTest.kt and WebViewDataManagerTest.kt reflecting new fireproof checks.
- Modifications to AndroidBrowserConfigFeature.kt and WebDataManager.kt to integrate IndexedDB feature flags.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/test/java/com/duckduckgo/app/browser/indexeddb/IndexedDBManagerTest.kt | Adds tests to validate various configurations for excluding IndexedDB folders. |
| app/src/main/java/com/duckduckgo/app/pixels/remoteconfig/AndroidBrowserConfigFeature.kt | Introduces new toggle methods with documentation for indexedDB and fireproofedIndexedDB features. |
| app/src/main/java/com/duckduckgo/app/browser/indexeddb/IndexedDBManager.kt | Implements logic to preserve fireproofed IndexedDB entries based on allowed domains. |
| app/src/main/java/com/duckduckgo/app/browser/WebDataManager.kt | Updates data-clearing logic to incorporate IndexedDB preservation based on feature toggles. |
| app/src/androidTest/java/com/duckduckgo/app/browser/WebViewDataManagerTest.kt | Verifies behavior when the IndexedDB feature is enabled, disabled, or throws exceptions. |
app/src/main/java/com/duckduckgo/app/browser/indexeddb/IndexedDBManager.kt
Show resolved
Hide resolved
nalcalag
approved these changes
May 19, 2025
Contributor
nalcalag
left a comment
There was a problem hiding this comment.
LGTM and works as expected
CrisBarreiro
pushed a commit
that referenced
this pull request
May 23, 2025
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1210223368584104?focus=true ### Description - Preserves `IndexedDB` entries for fireproofed sites. ### Steps to test this PR _Point at the config linked in the task_ - [x] Go to https://mdn.github.io/dom-examples/indexeddb-api/index.html - [x] Add a publication and fireproof the site - [x] Go to https://indexed-db-demo.davebitter.com/ - [x] Add a task and submit - [x] Use the fire button - [x] Go to https://mdn.github.io/dom-examples/indexeddb-api/index.html - [x] Tap “List database content" - [x] Verify that the entry is preserved - [x] Go to https://indexed-db-demo.davebitter.com/ - [x] Verify that no tasks are listed --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1210225196227164 - https://app.asana.com/0/0/1210236595890145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1210223368584104?focus=true
Description
IndexedDBentries for fireproofed sites.Steps to test this PR
Point at the config linked in the task