Skip to content

fix(types): replace Record<string, any> with Record<string, unknown> for message in utils.js #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonathanKingston wants to merge 16 commits into
base: main
Choose a base branch
from
+1 −1
Open

fix(types): replace Record<string, any> with Record<string, unknown> for message in utils.js #2365

Changes from 13 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2bea8bc
fix(types): replace Record<string, any> with Record<string, unknown> …
claude Feb 28, 2026
3e59cd2
Merge main into claude/fix-any-type-patch-09-sqf19
jonathanKingston Feb 28, 2026
e4b4849
Merge main into claude/fix-any-type-patch-09-sqf19
jonathanKingston Feb 28, 2026
5c37882
Merge main into claude/fix-any-type-patch-09-sqf19
jonathanKingston Mar 1, 2026
4dc3f36
Merge main into claude/fix-any-type-patch-09-sqf19
jonathanKingston Mar 2, 2026
e53cecd
Merge main into claude/fix-any-type-patch-09-sqf19
jonathanKingston Mar 2, 2026
c5fcb14
Merge main into claude/fix-any-type-patch-09-sqf19
jonathanKingston Mar 3, 2026
a084904
Merge main into claude/fix-any-type-patch-09-sqf19
jonathanKingston Mar 3, 2026
5c312aa
Merge main into claude/fix-any-type-patch-09-sqf19
jonathanKingston Mar 3, 2026
289a331
Merge main into claude/fix-any-type-patch-09-sqf19
jonathanKingston Mar 3, 2026
221b7a7
Merge main into claude/fix-any-type-patch-09-sqf19
jonathanKingston Mar 4, 2026
82ed6a7
Merge main into claude/fix-any-type-patch-09-sqf19
jonathanKingston Mar 5, 2026
552b151
Merge main into claude/fix-any-type-patch-09-sqf19
jonathanKingston Mar 5, 2026
6ee8784
Merge main into claude/fix-any-type-patch-09-sqf19
jonathanKingston Mar 5, 2026
7010240
Merge branch 'main' into claude/fix-any-type-patch-09-sqf19
jonathanKingston Mar 9, 2026
66bc28e
Merge main into claude/fix-any-type-patch-09-sqf19
jonathanKingston May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion injected/src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,7 @@

/**
* @param {string} feature
* @param {Record<string, any>} message
* @param {Record<string, unknown>} message
* @param {boolean} [allowNonDebug]
*/
export function postDebugMessage(feature, message, allowNonDebug = false) {
Copy link
Copy Markdown
Contributor

@cursor cursor Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This becomes a type-check failure with the new Record<string, unknown> annotation. message.stack is unknown; inside if (message.stack), TypeScript narrows it to {}, which is not assignable to getStackTraceOrigins(stack: string | undefined). A narrow typedef for debug messages, e.g. Record<string, unknown> & { stack?: string; scriptOrigins?: string[] }, keeps the any removal without breaking npm run tsc.

Expand All @@ -589,7 +589,7 @@
return;
}
if (message.stack) {
const scriptOrigins = [...getStackTraceOrigins(message.stack)];

Check failure on line 592 in injected/src/utils.js

View workflow job for this annotation

GitHub Actions / unit (ubuntu-latest) 

Argument of type '{}' is not assignable to parameter of type 'string'.
message.scriptOrigins = scriptOrigins;
}
globalObj.postMessage({
Expand Down
Loading