Additional metrics for breakage testing #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sammacbeth
force-pushed
the
sam/abn-dashboard-metrics
branch
from
a2dc4e4 to
7665739
Compare
sammacbeth
force-pushed
the
sam/abn-tds
branch
from
1798a56 to
20a9957
Compare
…ndle static access to the messaging port.
sammacbeth
force-pushed
the
sam/abn-dashboard-metrics
branch
from
7665739 to
d4936b5
Compare
kzar
requested changes
Jan 29, 2025
kzar
approved these changes
Jan 30, 2025
sammacbeth
force-pushed
the
sam/abn-dashboard-metrics
branch
from
759da78 to
c967c12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(stacked on top of #2906)
Adds additional metrics that can be used in A/B/N tests as proxies for breakage:
To do this, I've moved messaging to a component, allowing others to subscribe to the incoming messages, which we use to trigger appropriate metrics.