-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor broken site report message handlers #2939
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config processing can how take one tick after the config ready promise resolves. Waiting for allLoadingFinished should ensure that everything is ready.
kzar
reviewed
Feb 5, 2025
a8bc2fe
to
7f4d812
Compare
kzar
requested changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I like the changes, but can we split the race condition fix out from the refactor? Also, I'd like to avoid weakening the ToggleReports unit tests.
Co-authored-by: Dave Vandyke <[email protected]>
kzar
reviewed
Feb 17, 2025
kzar
reviewed
Feb 17, 2025
Co-authored-by: Dave Vandyke <[email protected]>
effbe1b
to
a7ef3f7
Compare
kzar
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer:
Description:
Some breakage reports were coming through with config version
undefined
on Firefox (https://app.asana.com/0/0/1209244730607066/f). This is likely caused by a race condition in the breakage report flow if the background is not fully loaded yet.To fix this, this PR:
Steps to test this PR:
Automated tests:
Reviewer Checklist:
PR Author Checklist: