Send enrollment dates in ET, and align conversion windows with ET days. #2950
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer:
Description:
Our A/B/N framework assumes that:
Our initial implementation used UTC dates (default for javascript
Date
objects), and using rolling windows, so this PR corrects that by:This also contains a fix for a potential race with the
app_use
metric. If it is triggered too early, we may not yet have the config processed and ready to handle metrics.Steps to test this PR:
Automated tests:
Reviewer Checklist:
PR Author Checklist: