Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

reset experiment #3832

Merged
merged 1 commit into from
Feb 6, 2025
Merged

reset experiment #3832

merged 1 commit into from
Feb 6, 2025

Conversation

SabrinaTardio
Copy link
Collaborator

@SabrinaTardio SabrinaTardio commented Feb 5, 2025

Task/Issue URL: https://app.asana.com/0/1204186595873227/1209311973888722

Description: Restart onboarding experiment with contextual onboarding

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:

  1. Run ./clean-app.sh debug
  2. In Tab.swift in shouldShowOnboarding returns comment out everything besides lines 94 and 95
  3. Run the app and should get one of the two onboardings
  4. Check the m_mac_onboarding_cohort-assigned pixel is sent with the right cohort (oh for the old and og for the new)
  5. Check that at the end of the old onboarding there is no contextual onboarding
  6. Check that at the end of the new onboarding there is the contextual onboarding

<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the DO NOT MERGE label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the Pending Product Review label.

If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

@alessandroboron alessandroboron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected! Instructions for cohort variants were flipped but I checked the code and it’s all good!

@SabrinaTardio SabrinaTardio merged commit 012d106 into main Feb 6, 2025
27 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/reset-onboarding-experiment branch February 6, 2025 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants