Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Fix toggle report not showing after user decides to send a report #3939 #3841

Closed
wants to merge 3 commits into from

Conversation

jaceklyp
Copy link
Contributor

@jaceklyp jaceklyp commented Feb 6, 2025

Task/Issue URL: https://app.asana.com/0/1201048563534612/1209117117981111

Description:
We are incorrectly recording user's choice to send a breakage report as dismissal.

Steps to test this PR:
See: duckduckgo/BrowserServicesKit#1220

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Fails
🚫

Please, make sure this PR satisfies our Definition of Done and the relevant checkbox is checked.

Generated by 🚫 dangerJS against d8b5a80

Copy link
Collaborator

@dharb dharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, just approved the BSK PR. I'll approve once you've updated the BSK references here.

@jaceklyp
Copy link
Contributor Author

has been included with another version of BSK, closing this one

@jaceklyp jaceklyp closed this Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants