Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password manager: Fix tabbing between text fields #3857

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

noisysocks
Copy link
Collaborator

@noisysocks noisysocks commented Feb 11, 2025

Task/Issue URL: https://app.asana.com/0/1209121419454298/1204477720783181

Description:

Fix tabbing between text fields in the password manager by manually recalculating key view loop in PasswordManagementViewController. This isn't done automatically as MainWindow disables autorecalculatesKeyViewLoop.

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:

  1. Click Open application menu (⋯)
  2. Click Passwords & Autofill
  3. Click Add item (+)
  4. Select any type of item, e.g. Password
  5. Focus on a text field, e.g. the title field
  6. Press Tab
  7. Focus should move to the next text field.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Fix tabbing between text fields in the password manager by manually
recalculating key view loop in PasswordManagementViewController. This
isn't done automatically as MainWindow disables
autorecalculatesKeyViewLoop.
Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as the diff is the same as the original PR

@noisysocks
Copy link
Collaborator Author

This was already approved in #3842. Recreated the PR to not use a fork so that tests run per @ayoy’s suggestion.

@noisysocks noisysocks merged commit 1678d98 into main Feb 11, 2025
38 of 43 checks passed
@noisysocks noisysocks deleted the noisysocks/fix-tabbing-in-passwords-manager branch February 11, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants