Skip to content

Comments

Update sodium and make it truly compat with 16kb page size#25

Merged
aitorvs merged 1 commit intomainfrom
feature/aitor/update-sodium
Jul 10, 2025
Merged

Update sodium and make it truly compat with 16kb page size#25
aitorvs merged 1 commit intomainfrom
feature/aitor/update-sodium

Conversation

@aitorvs
Copy link
Collaborator

@aitorvs aitorvs commented Jul 10, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1206705314358009?focus=true

Description

Update to central portal and fix 16kb page size compatibility

Testing

  • checkout this PR and execute
./gradlew clean assemble publishToMavenLocal
diff --git a/build.gradle b/build.gradle
index a620d932d..0b5cee9cd 100644
--- a/build.gradle
+++ b/build.gradle
@@ -42,6 +42,7 @@ allprojects {
         google()
         mavenCentral()
         maven { url 'https://jitpack.io' }
+        mavenLocal()
     }
     configurations.all {
         resolutionStrategy.force 'org.objenesis:objenesis:2.6'
diff --git a/versions.properties b/versions.properties
index f4547d0a1..82c9f20e7 100644
--- a/versions.properties
+++ b/versions.properties
@@ -81,7 +81,7 @@ version.com.android.installreferrer..installreferrer=2.2
 
 version.com.duckduckgo.netguard..netguard-android=1.10.2
 
-version.com.duckduckgo.synccrypto..sync-crypto-android=0.6.0
+version.com.duckduckgo.synccrypto..sync-crypto-android=0.6.0-SNAPSHOT
 
 version.com.frybits.harmony..harmony=1.2.6
   
  • Build the Android app
rm -rf build-cache/; ./gradlew clean assembleID
  • Install on device and test sync
  • Install on 16kb page size device and test sync
  • install on pixel 3a API 29 emulator and test sync

Copy link
Collaborator

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ony tested on the device that was previously crashing. Will test the 16kb device in the Android-15 branch (need to jump to a meeting now and I don't want to block this one)

@aitorvs aitorvs merged commit cc6f9ac into main Jul 10, 2025
4 of 6 checks passed
@aitorvs aitorvs deleted the feature/aitor/update-sodium branch July 10, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants