Add clickable menu #1436
Open
Add clickable menu #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qingwu-Li
force-pushed
the
add-clickable-menu
branch
2 times, most recently
from
fbc180d to
bbf6888
Compare
|
hello. I like your idea and I also wanted to implement the buttons. I tried your branch and noticed some problems with the text alignment
I think the best way would be to either specify a maximum amount of buttons allowed (then dmenu is used for extra action) or to wrap the buttons to a newline. squeezing all actions in a single line is impossible when there are a lot after all |
Qingwu-Li
force-pushed
the
add-clickable-menu
branch
3 times, most recently
from
181254a to
bd090c7
Compare
Implement menu structure and related functions, preparing for clickable menu feature. Add new menus array to preserve current actions. Signed-off-by: LI Qingwu <[email protected]>
Introduce built-in menu settings in dunstrc. Add corresponding settings in settings.h. Update settings_data.h with new menu-related options. Preparing for built-in clickable menu. Signed-off-by: LI Qingwu <[email protected]>
Qingwu-Li
force-pushed
the
add-clickable-menu
branch
from
bd090c7 to
3f14999
Compare
Add menu button drawing function. Update layout calculations for menu height. Integrate menu rendering into notification display. Signed-off-by: LI Qingwu <[email protected]>
Add function to handle built-in menu clicks. Trigger action invocation on menu button click. Signed-off-by: LI Qingwu <[email protected]>
Add menu_free_array call in notification_invalidate_actions, ensure proper cleanup of menu resources when invalidating actions Signed-off-by: LI Qingwu <[email protected]>
Qingwu-Li
force-pushed
the
add-clickable-menu
branch
from
3f14999 to
ce35eed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello fellow geeks,
I tring to implemented a built-in clickable menu feature,
Tested with wayland,