Use properties instead of private fields in dunstify

[bynect]

not tested properly but should work

[holytrousers]

hi @bynect ,
-r id started crashing with segmentation fault, now when compiling git version (using aur) it gives me this error that looks related to this commit :

dunstify.c: In function ‘get_id’:
dunstify.c:207:21: error: ‘NotifyNotification’ has no member named ‘priv’
  207 |     knickers *kn = n->priv;
      |                     ^~
dunstify.c: In function ‘put_id’:
dunstify.c:215:21: error: ‘NotifyNotification’ has no member named ‘priv’
  215 |     knickers *kn = n->priv;
      |                     ^~

[bynect]

hi @bynect ,
-r id started crashing with segmentation fault, now when compiling git version (using aur) it gives me this error that looks related to this commit :

dunstify.c: In function ‘get_id’:
dunstify.c:207:21: error: ‘NotifyNotification’ has no member named ‘priv’
  207 |     knickers *kn = n->priv;
      |                     ^~
dunstify.c: In function ‘put_id’:
dunstify.c:215:21: error: ‘NotifyNotification’ has no member named ‘priv’
  215 |     knickers *kn = n->priv;
      |                     ^~

Yes see #1443

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.32%. Comparing base (fe7f928) to head (2099296).
Report is 3 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1444   +/-   ##
=======================================
  Coverage   65.32%   65.32%           
=======================================
  Files          50       50           
  Lines        8763     8763           
  Branches     1034     1034           
=======================================
  Hits         5724     5724           
  Misses       3039     3039           

Flag	Coverage Δ
unittests	65.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[deftclaw]

Pulled v1.12.1, wouldn't build, switched to master. Built and -r function is working again, Thanks!

[liskin]

Hey, this is really weird… on Debian, this results in:

(dunstify:5973): GLib-GObject-CRITICAL **: 14:52:22.702: g_value_get_int: assertion 'G_VALUE_HOLDS_INT (value)' failed

Seems like an INT vs UINT mismatch. But upstream declares it as an int, not uint:
https://github.com/GNOME/libnotify/blob/570982f616838abba6bdd8ca2bdb2f32f3b1d1de/libnotify/notification.c#L167

So I'm really confused how this could work anywhere else. Any ideas?

If, one the other hand, I do what notify-send does:

int get_id(NotifyNotification *n)
{
    gint id;
    g_object_get(G_OBJECT(n), "id", &id, NULL);
    return id;
}

then it works just fine.

[bynect]

This is very strange since ids are represented as uint (https://specifications.freedesktop.org/notification-spec/latest/protocol.html#id-1.10.3.3.4). Also that code is ignoring the fact that upstream thinks that the value should be an int. I'll have to check the code of libnotify

[bynect]

Also what version of debian/libnotify are you on?

[liskin]

This is very strange since ids are represented as uint (https://specifications.freedesktop.org/notification-spec/latest/protocol.html#id-1.10.3.3.4). Also that code is ignoring the fact that upstream thinks that the value should be an int. I'll have to check the code of libnotify

Yeah they probably are uint in the dbus protocol but the property is declared in libnotify as int here: https://github.com/GNOME/libnotify/blob/570982f616838abba6bdd8ca2bdb2f32f3b1d1de/libnotify/notification.c#L167

Also what version of debian/libnotify are you on?

0.8.4-1

[liskin]

Is it possible that Debian enables assertions and whatever build of libnotify you have doesn't?

[bynect]

I guess so. I'm on gentoo, but maybe that's more of a glib configuration? Anyway I'll just change it like notifysend does

[bynect]

eaee466