Reduce bundle size by 66% #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkpatchaa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an effort to reduce the bundle size and the result is very significant.
Current unpacked version is 69.8 MB.
With the new generation process, the unpacked size is 23.1 MB
I implemented the same logic as on @phosphor-icons/react with specific use cases for React Native (duotone)
Related to #61
Closes #28 because it will considerably reduce the number of files.
Tests on a real app with expo-atlas
Before
After
@duongdev The update should be seamless but I suggest We bump version to 2.3 at least or 3.0 if this is validated.