This repository was archived by the owner on Feb 21, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 48
Make repo management optional #18
Open
mrbanzai
wants to merge
10
commits into
duosecurity:master
Choose a base branch
from
mrbanzai:manage_repo_optional
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to use duo_unix to configure and install duo itself, but we want to configure the actual pam stack manually. Setting manage_pam => false prevents the module from editing password-auth or other pam files.
…late-params inherit duo_unix class for params in template
Add manage_pam configuration parameter
Per https://duo.com/docs/duounix this is groups not group
Update duo.conf.erb
Any chance of this being merged if conflicts are resolved? I can send a follow-up PR doing so if OP isn't around anymore. |
…_unix into manage_repo_optional
Rebased against master, to resolve conflicts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to be able to skip / disable repo creation, especially when using local mirrors for upstream packages (so deployments and provisioning are not dependent on Internet connectivity at build-time). This PR adds a
manage_repo
flag (defaulting totrue
) to allow control over the creation and usage of upstream apt / yum repositories.