Skip to content

Conversation

@LuchoTurtle
Copy link
Member

closes #1

This PR implements both Material (through datePicker and timePicker) and inline scenarios for mutating DateTime objects in Flutter.
The README documents the process on both occasions and is also tested.

@LuchoTurtle LuchoTurtle added documentation Improvements or additions to documentation enhancement New feature or enhancement of existing functionality flutter Flutter related issues in-progress An issue or pull request that is being worked on by the assigned person labels Jul 25, 2023
@LuchoTurtle LuchoTurtle self-assigned this Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@871a89e). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main        #2   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         3           
  Lines           ?       148           
  Branches        ?         0           
========================================
  Hits            ?       148           
  Misses          ?         0           
  Partials        ?         0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LuchoTurtle
Copy link
Member Author

LuchoTurtle commented Jul 26, 2023

@nelsonic
This should be reviewable and mergeable.
I've added tests to cover each scenario and GH workflow to run these tests.
I've also added a simple incrementing counter to showcase how easy it is to use callbacks to track how many times the person is updating the dateTime field.

I didn't add a deploy workflow. I want to leave this for a separate PR.

@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Jul 26, 2023
@LuchoTurtle LuchoTurtle removed their assignment Jul 26, 2023
@LuchoTurtle LuchoTurtle marked this pull request as ready for review July 26, 2023 16:15
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuchoTurtle Looks good. Thanks.👌

@nelsonic nelsonic merged commit 8cfba34 into main Jul 26, 2023
@nelsonic nelsonic deleted the initial_#1 branch July 26, 2023 19:23
@panoramix360
Copy link

👀

That's really nice guys!

@LuchoTurtle
Copy link
Member Author

It's just a simple demo @panoramix360 but thanks 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review An issue or pull request that needs to be reviewed documentation Improvements or additions to documentation enhancement New feature or enhancement of existing functionality flutter Flutter related issues

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Feat: Setup + Document date and time input in a Flutter App

4 participants