Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check on person name #182

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Remove check on person name #182

merged 1 commit into from
Oct 20, 2022

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Oct 19, 2022

Allow anyone to access the application
related to: #174
This should also fix #172

Allow anyone to access the application
related to: #174
@SimonLab SimonLab temporarily deployed to dwylauth October 19, 2022 11:27 Inactive
@SimonLab SimonLab marked this pull request as ready for review October 19, 2022 11:31
@SimonLab SimonLab requested a review from nelsonic October 19, 2022 11:31
@SimonLab SimonLab added the awaiting-review An issue or pull request that needs to be reviewed label Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #182 (a0ca715) into main (4da9388) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #182   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          219       218    -1     
=========================================
- Hits           219       218    -1     
Impacted Files Coverage Δ
lib/app/person.ex 100.00% <100.00%> (ø)
lib/app_web/router.ex 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab thanks for removing this check. ✅
Ideally we wouldn't have any Person schema in this project as per: #118 ✂️
But we can revisit later. ⏳
Thanks. 👌

@nelsonic nelsonic merged commit bc8d2b3 into main Oct 20, 2022
@nelsonic nelsonic deleted the allow-guests-#174 branch October 20, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review An issue or pull request that needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Edit Profile Wall Before Being Allowed to Use the App
2 participants