feat(app): Upgrading to v50 #1736
Conversation
bumped PFM to v8 deprecated usage of /store/types
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for _, m := range app.mm.Modules { | ||
| if moduleWithName, ok := m.(module.HasName); ok { | ||
| moduleName := moduleWithName.Name() | ||
| if appModule, ok := moduleWithName.(appmodule.AppModule); ok { | ||
| modules[moduleName] = appModule | ||
| } | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
| a.AccountKeeper, | ||
| a.BankKeeper, | ||
| govModuleAddress, | ||
| appCodec, runtime.NewKVStoreService(a.keys[stakingtypes.StoreKey]), a.AccountKeeper, a.BankKeeper, authtypes.NewModuleAddress(govtypes.ModuleName).String(), authcodec.NewBech32Codec(appparams.Bech32PrefixValAddr), authcodec.NewBech32Codec(appparams.Bech32PrefixConsAddr), |
Check warning
Code scanning / CodeQL
Directly using the bech32 constants Warning
| a.AccountKeeper, | ||
| a.BankKeeper, | ||
| govModuleAddress, | ||
| appCodec, runtime.NewKVStoreService(a.keys[stakingtypes.StoreKey]), a.AccountKeeper, a.BankKeeper, authtypes.NewModuleAddress(govtypes.ModuleName).String(), authcodec.NewBech32Codec(appparams.Bech32PrefixValAddr), authcodec.NewBech32Codec(appparams.Bech32PrefixConsAddr), |
Check warning
Code scanning / CodeQL
Directly using the bech32 constants Warning
| @@ -18,26 +21,37 @@ | |||
| BaseDenomUnit = 18 | |||
|
|
|||
| AccountAddressPrefix = "dym" | |||
| Name = "dymension" | |||
| ) | |||
| Bech32MainPrefix = AccountAddressPrefix | |||
Check warning
Code scanning / CodeQL
Directly using the bech32 constants Warning
| // Bech32PrefixConsAddr defines the Bech32 prefix of a consensus node address | ||
| Bech32PrefixConsAddr = Bech32MainPrefix + PrefixValidator + PrefixConsensus | ||
| // Bech32PrefixConsPub defines the Bech32 prefix of a consensus node public key | ||
| Bech32PrefixConsPub = Bech32MainPrefix + PrefixValidator + PrefixConsensus + PrefixPublic |
Check warning
Code scanning / CodeQL
Directly using the bech32 constants Warning
| // Bech32PrefixConsAddr defines the Bech32 prefix of a consensus node address | ||
| Bech32PrefixConsAddr = Bech32MainPrefix + PrefixValidator + PrefixConsensus | ||
| // Bech32PrefixConsPub defines the Bech32 prefix of a consensus node public key | ||
| Bech32PrefixConsPub = Bech32MainPrefix + PrefixValidator + PrefixConsensus + PrefixPublic |
Check warning
Code scanning / CodeQL
Directly using the bech32 constants Warning
This PR bumps the dymension repo to use
cosmos-sdk v50.xthe main changes besides the straightforward syntax changes:
legacytxMsg interface and the deprecated global amino variablesFew technical debts left:
msg.ValidateBasicinto the message handler #1742