Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update remote participants section for mobile-core v2 #411

Merged
merged 6 commits into from
Jan 6, 2025
Merged

docs: update remote participants section for mobile-core v2 #411

merged 6 commits into from
Jan 6, 2025

Conversation

harshs-dyte
Copy link
Contributor

Resolved issues

Fixes MOB-1904
Fixes MOB-1921

Before submitting the PR, please take the following into consideration

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. If you don't have an issue, please create one.
  • Prefix your PR title with feat: , fix: , chore: , docs:, or refactor:.
  • The description should clearly illustrate what problems it solves.
  • Ensure that the commit messages follow our guidelines.
  • Resolve merge conflicts (if any).
  • Make sure that the current branch is upto date with the main branch.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 26, 2024 •
edited
Loading

Deploying dyte-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c04a8d9
Status: ✅  Deploy successful!
Preview URL: https://1bc0f454.dyte-docs.pages.dev
Branch Preview URL: https://hs-remote-participants-v2.dyte-docs.pages.dev

View logs

swapnilmadavi
swapnilmadavi requested changes Jan 6, 2025
View reviewed changes
docs/android-core/participants/remote-participants.mdx Outdated Show resolved Hide resolved
docs/android-core/participants/remote-participants.mdx Show resolved Hide resolved
docs/android-core/participants/events.mdx Show resolved Hide resolved
docs/android-core/participants/events.mdx Outdated Show resolved Hide resolved
docs/android-core/participants/events.mdx Outdated Show resolved Hide resolved
docs/android-core/participants/events.mdx Outdated Show resolved Hide resolved
docs/android-core/participants/events.mdx Outdated Show resolved Hide resolved
docs/android-core/participants/events.mdx Outdated Show resolved Hide resolved
docs/android-core/participants/events.mdx Show resolved Hide resolved
docs/android-core/participants/waitlisted-participants.mdx Outdated Show resolved Hide resolved
@swapnilmadavi swapnilmadavi self-requested a review January 6, 2025 08:57
swapnilmadavi
swapnilmadavi approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@swapnilmadavi swapnilmadavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the review comments and merge. 👍

@harshs-dyte harshs-dyte merged commit 561f6c2 into main Jan 6, 2025
2 checks passed
@harshs-dyte harshs-dyte deleted the hs/remote-participants-v2 branch January 6, 2025 10:01
@swapnilmadavi swapnilmadavi mentioned this pull request Jan 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapnilmadavi swapnilmadavi swapnilmadavi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshs-dyte @swapnilmadavi