Skip to content

fix(angular): keepLifecycleScripts #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2025
Merged

fix(angular): keepLifecycleScripts #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ed24d1
fix(angular): keepLifecycleScripts
vaibhavshn Aug 6, 2025
9f9d406
fix(angular): prepublish script
vaibhavshn Aug 6, 2025
fe8a066
fix(angular): scripts
vaibhavshn Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
dist/
dist/package.json
loader/
node_modules/
tmp/
Expand Down
3 changes: 3 additions & 0 deletions packages/angular-library/projects/components/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
dist
dist/package.json
package.json.bak
44 changes: 0 additions & 44 deletions packages/angular-library/projects/components/dist/package.json
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions packages/angular-library/projects/components/ng-package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@
"lib": {
"entryFile": "src/public-api.ts"
},
"keepLifecycleScripts": true,
"allowedNonPeerDependencies": ["@dytesdk/ui-kit"]
}
3 changes: 1 addition & 2 deletions packages/angular-library/projects/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
},
"sideEffects": false,
"scripts": {
"prepublishOnly": "cp package.json package.json.bak && node prepublish.js",
"postpublish": "mv package.json.bak package.json"
"prepublishOnly": "node prepublish.js"
}
}
6 changes: 3 additions & 3 deletions packages/angular-library/projects/components/prepublish.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
const fs = require('fs');
if (!fs.existsSync('./dist/package.json')) {
if (!fs.existsSync('./package.json')) {
throw new Error('Angular UI Kit dist not found');
}
const pkg = require('./dist/package.json');
const pkg = require('./package.json');

const dependencies = {
...pkg.dependencies,
Expand All @@ -16,7 +16,7 @@ const tag = env == 'main' ? 'latest' : env;
console.log('angular-ui-kit: prepublish:env', { env, tag });

fs.writeFileSync(
'./dist/package.json',
'./package.json',
JSON.stringify(
{
...pkg,
Expand Down
Loading