Merge pull request #344 from e-picsa/chore/core-updates

chore: core updates
e-picsa · Jan 6, 2025 · 7c281b8 · 7c281b8
2 parents 43d0d28 + 0125a15
commit 7c281b8
Show file tree

Hide file tree

Showing 207 changed files with 12,740 additions and 13,256 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -35,12 +35,18 @@
     {
       "files": ["*.ts", "*.tsx"],
       "extends": ["plugin:@nx/typescript", "prettier"],
-      "rules": {}
+      "rules": {
+        "@typescript-eslint/no-extra-semi": "error",
+        "no-extra-semi": "off"
+      }
     },
     {
       "files": ["*.js", "*.jsx"],
       "extends": ["plugin:@nx/javascript"],
-      "rules": {}
+      "rules": {
+        "@typescript-eslint/no-extra-semi": "error",
+        "no-extra-semi": "off"
+      }
     }
   ]
 }
diff --git a/.github/workflows/android-release.yml b/.github/workflows/android-release.yml
@@ -20,33 +20,18 @@ jobs:
   android_release:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           lfs: true
       - name: Setup Node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 18.x
-      #############################################################################
-      #         Node Modules
-      # Manually restore any previous cache to speed install
-      # As immutable install will not change cache only save new cache if not hit
-      # Uses fine-grained methods from https://github.com/actions/cache
-      #############################################################################
-      - uses: actions/cache/restore@v3
-        id: cache
-        with:
-          path: ./.yarn/cache
-          key: ${{ runner.os }}-node-modules-yarn-v1-${{ hashFiles('yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-node-modules-yarn-v1-
+          node-version: 22.x
+          cache: 'yarn'
+
       - name: Install node modules
         run: yarn install --immutable
-      - uses: actions/cache/save@v3
-        if: steps.cache.outputs.cache-hit != 'true'
-        with:
-          path: ./.yarn/cache
-          key: ${{ runner.os }}-node-modules-yarn-v1-${{ hashFiles('yarn.lock') }}
+
       - name: Populate google-services.json
         env:
           GOOGLE_SERVICES_JSON: ${{ secrets.GOOGLE_SERVICES_JSON }}

diff --git a/.github/workflows/build-test.yml b/.github/workflows/build-test.yml
@@ -5,37 +5,28 @@ on:
   pull_request:
     branches:
       - main
+
+# Only keep one active build per ref (e.g. pr branch, push branch, triggering workflow ref)
+concurrency:
+  group: app-build-${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           lfs: true
       - name: Setup Node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 18.x
-      #############################################################################
-      #         Node Modules
-      # Manually restore any previous cache to speed install
-      # As immutable install will not change cache only save new cache if not hit
-      # Uses fine-grained methods from https://github.com/actions/cache
-      #############################################################################
-      - uses: actions/cache/restore@v3
-        id: cache
+        uses: actions/setup-node@v4
         with:
-          path: ./.yarn/cache
-          key: ${{ runner.os }}-node-modules-yarn-v1-${{ hashFiles('yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-node-modules-yarn-v1-
+          node-version: 22.x
+          cache: 'yarn'
+
       - name: Install node modules
         run: yarn install --immutable
-      - uses: actions/cache/save@v3
-        if: steps.cache.outputs.cache-hit != 'true'
-        with:
-          path: ./.yarn/cache
-          key: ${{ runner.os }}-node-modules-yarn-v1-${{ hashFiles('yarn.lock') }}
+
       - run: yarn lint
       # - run: yarn nx test
       # Ensure can also build

diff --git a/.github/workflows/web-preview.yml b/.github/workflows/web-preview.yml
@@ -14,33 +14,18 @@ jobs:
     if: contains(github.event.pull_request.labels.*.name, 'Test - Preview')
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           lfs: true
       - name: Setup Node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 18.x
-      #############################################################################
-      #         Node Modules
-      # Manually restore any previous cache to speed install
-      # As immutable install will not change cache only save new cache if not hit
-      # Uses fine-grained methods from https://github.com/actions/cache
-      #############################################################################
-      - uses: actions/cache/restore@v3
-        id: cache
-        with:
-          path: ./.yarn/cache
-          key: ${{ runner.os }}-node-modules-yarn-v1-${{ hashFiles('yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-node-modules-yarn-v1-
+          node-version: 22.x
+          cache: 'yarn'
+
       - name: Install node modules
         run: yarn install --immutable
-      - uses: actions/cache/save@v3
-        if: steps.cache.outputs.cache-hit != 'true'
-        with:
-          path: ./.yarn/cache
-          key: ${{ runner.os }}-node-modules-yarn-v1-${{ hashFiles('yarn.lock') }}
+
       - run: yarn nx run picsa-apps-extension-app:build
       - uses: FirebaseExtended/action-hosting-deploy@v0
         with:

diff --git a/.github/workflows/web-release-dashboard.yml b/.github/workflows/web-release-dashboard.yml
@@ -32,36 +32,18 @@ jobs:
     runs-on: ubuntu-latest
     environment: dashboard
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           lfs: true
       - name: Setup Node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 18.x
-      #############################################################################
-      #         Node Modules
-      # Manually restore any previous cache to speed install
-      # As immutable install will not change cache only save new cache if not hit
-      # Uses fine-grained methods from https://github.com/actions/cache
-      #############################################################################
-      - uses: actions/cache/restore@v3
-        id: cache
-        with:
-          path: ./.yarn/cache
-          key: ${{ runner.os }}-node-modules-yarn-v1-${{ hashFiles('yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-node-modules-yarn-v1-
+          node-version: 22.x
+          cache: 'yarn'
 
       - name: Install node modules
         run: yarn install --immutable && npm i -g vercel
 
-      - uses: actions/cache/save@v3
-        if: steps.cache.outputs.cache-hit != 'true'
-        with:
-          path: ./.yarn/cache
-          key: ${{ runner.os }}-node-modules-yarn-v1-${{ hashFiles('yarn.lock') }}
-
       - name: Pull Vercel Environment Information
         run: vercel pull --yes --environment=production --token=${{ secrets.VERCEL_TOKEN }}
 

diff --git a/.github/workflows/web-release.yml b/.github/workflows/web-release.yml
@@ -15,33 +15,18 @@ jobs:
   web_release:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           lfs: true
       - name: Setup Node
-        uses: actions/setup-node@v3
+        uses: actions/setup-node@v4
         with:
-          node-version: 18.x
-      #############################################################################
-      #         Node Modules
-      # Manually restore any previous cache to speed install
-      # As immutable install will not change cache only save new cache if not hit
-      # Uses fine-grained methods from https://github.com/actions/cache
-      #############################################################################
-      - uses: actions/cache/restore@v3
-        id: cache
-        with:
-          path: ./.yarn/cache
-          key: ${{ runner.os }}-node-modules-yarn-v1-${{ hashFiles('yarn.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-node-modules-yarn-v1-
+          node-version: 22.x
+          cache: 'yarn'
+
       - name: Install node modules
         run: yarn install --immutable
-      - uses: actions/cache/save@v3
-        if: steps.cache.outputs.cache-hit != 'true'
-        with:
-          path: ./.yarn/cache
-          key: ${{ runner.os }}-node-modules-yarn-v1-${{ hashFiles('yarn.lock') }}
+
       - run: yarn nx run picsa-apps-extension-app:build
       - uses: FirebaseExtended/action-hosting-deploy@v0
         with:

diff --git a/.gitignore b/.gitignore
@@ -80,3 +80,4 @@ apps/extension-toolkit/www_sourcemaps
 .eslintcache
 .nx/cache
 .vercel
+.nx
diff --git a/.yarn/releases/yarn-3.6.3.cjs b/.yarn/releases/yarn-3.6.3.cjs
-Original file line number
+Diff line change
@@ Expand Up / @@ -80,3 +80,4 @@ apps/extension-toolkit/www_sourcemaps @@
     .eslintcache
     .nx/cache
     .vercel
+    .nx