Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(seasonal-calendar): add translations #203

Merged
merged 8 commits into from
Jan 17, 2024

Conversation

khalifan-kfan
Copy link
Collaborator

Description

This PR is to enable translation on the seasonal calendar tool

Discussion

Building the seasonal calender

Preview

Screenshots / Videos

Copy link
Collaborator

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @khalifan-kfan

I noticed a typo in the scripts that extracts translations which explains why they weren't generating as expected, so I've fixed and rerun the extraction process yarn:i18n and now can see correctly the additional strings marked for translation

image

With the additional translations extracted, it is now possible to verify what strings have been marked for translation from the frontend by using the Translators preview language select option

image

When looking at the seasonal-calendar home page I can see all strings correctly have the markers indicating that they are linked up to translations

image

However when I try to create a new seasonal calendar I hit an error and blank page (likely an issue in the html code, somewhere you are using text 85}})

image

So when you get a chance can you fix the error, and continue in the same way to check whether all translations are marked as expected, and if not try to get them included.

Any new translations marked will appear in the list after you rerun the yarn i18n script

@khalifan-kfan
Copy link
Collaborator Author

Sure thanks @chrismclarke , I am going to work on this feedback

@khalifan-kfan
Copy link
Collaborator Author

Hello @chrismclarke, thanks for the feedback and help.
All changes have been worked on.

@chrismclarke
Copy link
Collaborator

Thanks @khalifan-kfan !

I found a few minor strings without translation (e.g. some of the error messages, the months dropdown), so have updated them in
efd8ad7 and ae33619

image

I also noticed it wasn't possible to translate the crop names on the table as the table essentially populates a crop id and not the label. I think probably easiest if we merge this PR here and I'll try to add a follow-up with any required data schema and binding changes. Thanks again for making the changes

@chrismclarke chrismclarke changed the title Enable translation in the seasonal calendar tool feat(seasonal-calendar): add translations Jan 17, 2024
@chrismclarke chrismclarke added the Tool: Seasonal Calendar Updates related to Seasonal Calendar tool label Jan 17, 2024
@chrismclarke chrismclarke merged commit 9faec91 into main Jan 17, 2024
5 checks passed
@chrismclarke chrismclarke deleted the ft-calendar-transalation branch January 17, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Tool: Seasonal Calendar Updates related to Seasonal Calendar tool
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants