Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: shared icons and data #225

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Refactor: shared icons and data #225

merged 7 commits into from
Jan 30, 2024

Conversation

chrismclarke
Copy link
Collaborator

@chrismclarke chrismclarke commented Jan 28, 2024

TODO

Description

Previously all tools managed their own system for storing and registering custom svg icons (e.g. crop images). This has a couple of issues as the codebase grows larger, namely duplication of assets or icon conflicts where multiple tools use the same name for different icons.

Some work has already been previously done in #224 to start the process of setting up shared registries for data and icons, this PR continues to build by registing icons with namespaces (e.g. the clear icon for use in weather is weather:clear to avoid conflict with a general clear icon which might be to remove data entry).

It also removes some of the existing duplication across crop icons, merging data so that all tools using icons have access to full lists of data

Discussion

Just to note that not all cards have been migrated to shared system. Notably budget activities are still handled separately to season calendar activities

Preview

Example - seasonal calendar tool now has access to the full list of crop options available within budget and crop probability tools
localhost_4200_seasonal-calendar_ZZTPngIvCnegmAk3SFlN

Screenshots / Videos

Include at least 1-2 screenshots of videos if visual changes

@github-actions github-actions bot added Tool: Climate Updates related to Climate tool Tool: Option Updates related to Option tool Tool: Crop Probability Updates related to Crop Probability tool Tool: Monitoring Updates related to Monitoring tool Tool: Manual Updates related to Manual tool Tool: Budget Updates related to Budget tool App: Dashboard Updates related to Dashboard app Tool: Resources Updates related to Resources tool Tool: Farmer Activity Updates related to Farmer Activity tool Tool: Seasonal Calendar Updates related to Seasonal Calendar tool labels Jan 28, 2024
@chrismclarke chrismclarke changed the title Refactor/crop data Refactor: shared icons and data Jan 28, 2024
@github-actions github-actions bot removed Tool: Monitoring Updates related to Monitoring tool App: Dashboard Updates related to Dashboard app labels Jan 30, 2024
@chrismclarke chrismclarke marked this pull request as ready for review January 30, 2024 04:38
@chrismclarke chrismclarke merged commit 50b3325 into main Jan 30, 2024
6 checks passed
@chrismclarke chrismclarke deleted the refactor/crop-data branch January 30, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tool: Budget Updates related to Budget tool Tool: Climate Updates related to Climate tool Tool: Crop Probability Updates related to Crop Probability tool Tool: Farmer Activity Updates related to Farmer Activity tool Tool: Manual Updates related to Manual tool Tool: Option Updates related to Option tool Tool: Resources Updates related to Resources tool Tool: Seasonal Calendar Updates related to Seasonal Calendar tool
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant