Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Description
Previously all tools managed their own system for storing and registering custom svg icons (e.g. crop images). This has a couple of issues as the codebase grows larger, namely duplication of assets or icon conflicts where multiple tools use the same name for different icons.
Some work has already been previously done in #224 to start the process of setting up shared registries for data and icons, this PR continues to build by registing icons with namespaces (e.g. the
clear
icon for use in weather isweather:clear
to avoid conflict with a generalclear
icon which might be to remove data entry).It also removes some of the existing duplication across crop icons, merging data so that all tools using icons have access to full lists of data
Discussion
Just to note that not all cards have been migrated to shared system. Notably budget activities are still handled separately to season calendar activities
Preview
Example - seasonal calendar tool now has access to the full list of crop options available within budget and crop probability tools

Screenshots / Videos
Include at least 1-2 screenshots of videos if visual changes