Ft link search text to route navigation #235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(core): data table custom value templates and header formatter
Feat/dashboard station forecasts
Pamella014
added
ready for review
Tool: Resources
github-actions
bot
added
App: Dashboard
|
Hi @Pamella014
There's no harm performing this merge as it will just update your feature branch with the latest code from main, however it does not request the changes that you have worked on to be merged into main, for that you would expect merge
I'm going to close this PR. Can you please open a new one with the code changes you have worked on instead? Looking briefly at the branch it seems that none of your updates have been applied, so you might still need to push from your local branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was able to link the search text to route navigation so that when the user leaves the search page and comes back they are able to see with a pre-built search term
Screenshots / Videos
screenshot showing the query params in the route
video showing a short demonstration
Picsa.Extension.webm
Include at least 1-2 screenshots of videos if visual changes