Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: show play update prompt #357

Merged
merged 9 commits into from
Mar 4, 2025
Merged

Conversation

Pamella014
Copy link
Collaborator

@Pamella014 Pamella014 commented Jan 30, 2025

Description

Created an app update service that can be accessed anywhere in the app and then i imported it into the main extension app entry component.

closes #348

@github-actions github-actions bot added the App: Extension Updates related to Farmer app label Jan 30, 2025
Copy link

nx-cloud bot commented Jan 30, 2025

View your CI Pipeline Execution ↗ for commit 5189d64.

Command Status Duration Result
nx build ✅ Succeeded 5m 24s View ↗
nx run-many --target=lint ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-04 18:49:14 UTC

@Pamella014 Pamella014 removed the App: Extension Updates related to Farmer app label Jan 30, 2025
Copy link
Collaborator

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pamella014
Thanks for making the changes to isolate the code in a service, I think overall is looking in a good state. See a few minor comments inline that it would be good to tidy up, and after that I will try to get a testing version deployed so we can confirm if behaves as expected

@Pamella014
Copy link
Collaborator Author

Pamella014 commented Jan 30, 2025

Thank you @chrismclarke for the feedback. I will review and make the necessary changes. Should i create a new pr once i am done?

@Pamella014
Copy link
Collaborator Author

@chrismclarke
I have made the requested changes and pushed.

@chrismclarke chrismclarke self-requested a review March 4, 2025 18:42
Copy link
Collaborator

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates @Pamella014 , and again apologies for the delayed review.

This will be merged and included in the next release (3.53.0), so it won't be until one more release later that we will be able to see if working as expected or not as it will only show when a new version is available after the user has this version installed. But will keep an eye out for it and let you know if any follow-up required.

@chrismclarke chrismclarke added the App: Extension Updates related to Farmer app label Mar 4, 2025
@chrismclarke chrismclarke changed the title Ft/show prompt of update Feat: show play update prompt Mar 4, 2025
@chrismclarke chrismclarke merged commit e0848ad into main Mar 4, 2025
7 checks passed
@chrismclarke chrismclarke deleted the ft/show-prompt-of-update branch March 4, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat(android): show prompt when app update is available
2 participants