Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: pdf compatibility, native build and web deployment #365

Merged
merged 10 commits into from
Mar 1, 2025

Conversation

chrismclarke
Copy link
Collaborator

@chrismclarke chrismclarke commented Feb 28, 2025

Description

  • Fix issue where custom notes in package.json prevent firebase deployment from working
  • Fix issue where db would not work if testing on local android device
  • Improve pdf viewer compatibility checker and error handling

Discussion

As some of these updates are only required for displaying PDFs not sure whether it should be prompted on first app load or only when accessing PDFs. Currently when accessing PDFs as assuming may be a number of users of farmer app who do not access manual or pdf forecasts

Preview

Example - PDF Viewer message informing user to update if not supported
image

Screenshots / Videos

Include at least 1-2 screenshots of videos if visual changes

Copy link

nx-cloud bot commented Feb 28, 2025

View your CI Pipeline Execution ↗ for commit f964fe0.

Command Status Duration Result
nx run picsa-apps-extension-app:build ✅ Succeeded 5m 22s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-01 17:20:26 UTC

Copy link

github-actions bot commented Feb 28, 2025

Visit the preview URL for this PR (updated for commit f964fe0):

https://picsa-extension-toolkit--pr365-fix-firebase-deploym-ncjacu4t.web.app

(expires Mon, 31 Mar 2025 17:20:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2435c4a5f2b9750fe5c819a7a14bcf9433816983

@chrismclarke chrismclarke changed the title Fix: firebase deployment Fix: native build and web deployment Feb 28, 2025
@github-actions github-actions bot added fix and removed fix labels Feb 28, 2025
@github-actions github-actions bot added Tool: Manual Updates related to Manual tool Tool: Resources Updates related to Resources tool fix and removed fix labels Mar 1, 2025
@chrismclarke chrismclarke removed Test - Preview Tool: Resources Updates related to Resources tool labels Mar 1, 2025
@github-actions github-actions bot removed the fix label Mar 1, 2025
@github-actions github-actions bot added the fix label Mar 1, 2025
@chrismclarke chrismclarke merged commit de4a878 into main Mar 1, 2025
6 checks passed
@chrismclarke chrismclarke deleted the fix/firebase-deployment branch March 1, 2025 18:14
@chrismclarke chrismclarke changed the title Fix: native build and web deployment Fix: pdf viewer, native build and web deployment Mar 1, 2025
@chrismclarke chrismclarke changed the title Fix: pdf viewer, native build and web deployment Fix: pdf compatibility, native build and web deployment Mar 1, 2025
@github-actions github-actions bot added fix and removed fix labels Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Tool: Manual Updates related to Manual tool
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant