-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: pdf compatibility, native build and web deployment #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your CI Pipeline Execution ↗ for commit f964fe0.
☁️ Nx Cloud last updated this comment at |
Visit the preview URL for this PR (updated for commit f964fe0): https://picsa-extension-toolkit--pr365-fix-firebase-deploym-ncjacu4t.web.app (expires Mon, 31 Mar 2025 17:20:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2435c4a5f2b9750fe5c819a7a14bcf9433816983 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discussion
As some of these updates are only required for displaying PDFs not sure whether it should be prompted on first app load or only when accessing PDFs. Currently when accessing PDFs as assuming may be a number of users of farmer app who do not access manual or pdf forecasts
Preview
Example - PDF Viewer message informing user to update if not supported

Screenshots / Videos
Include at least 1-2 screenshots of videos if visual changes