Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1917 improved imports #2512

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

KS-HTK
Copy link
Collaborator

@KS-HTK KS-HTK commented Jan 22, 2025

removed all imports that depend on the __init__.py containing imports for all files.
updated all code to not use import pandapower as pp

minor typo corrections
fixed a bug where function call was not complete
# Conflicts:
#	pandapower/converter/powerfactory/pp_import_functions.py
#	pandapower/plotting/plotly/mapbox_plot.py
#	pandapower/test/api/test_create.py
#	pandapower/test/api/test_group.py
#	pandapower/test/estimation/test_recycle.py
#	pandapower/test/estimation/test_wls_estimation.py
@KS-HTK KS-HTK requested a review from vogt31337 January 22, 2025 09:16
@KS-HTK KS-HTK mentioned this pull request Jan 22, 2025
9 tasks
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 76.64360% with 270 lines in your changes missing coverage. Please review.

Project coverage is 75.59%. Comparing base (8009cb5) to head (087976c).

Files with missing lines Patch % Lines
...ower/converter/powerfactory/pp_import_functions.py 5.42% 122 Missing ⚠️
pandapower/protection/example_grids.py 0.00% 34 Missing ⚠️
pandapower/plotting/collections.py 26.47% 25 Missing ⚠️
pandapower/protection/utility_functions.py 56.89% 25 Missing ⚠️
pandapower/grid_equivalents/auxiliary.py 78.33% 13 Missing ⚠️
pandapower/converter/powerfactory/main_pf.py 0.00% 8 Missing ⚠️
pandapower/converter/cim/pp_classes.py 0.00% 5 Missing ⚠️
...er/control/controller/DERController/der_control.py 50.00% 4 Missing ⚠️
pandapower/converter/cim/pp_tools.py 55.55% 4 Missing ⚠️
pandapower/diagnostic.py 63.63% 4 Missing ⚠️
... and 16 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2512      +/-   ##
===========================================
+ Coverage    75.56%   75.59%   +0.02%     
===========================================
  Files          284      284              
  Lines        33817    33840      +23     
===========================================
+ Hits         25555    25581      +26     
+ Misses        8262     8259       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant