introduce MCAP CLI tool during installation just as a reference. #111
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujitatomoya
commented
Jan 13, 2024
|
@juanlofer-eprosima can you take a look when you have time? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage 19.26% 19.26%
=======================================
Files 32 32
Lines 2829 2829
Branches 1499 1499
=======================================
Hits 545 545
Misses 1799 1799
Partials 485 485 ☔ View full report in Codecov by Sentry. |
rsanchez15
approved these changes
Jan 15, 2024
rsanchez15
requested changes
Jan 16, 2024
There was a problem hiding this comment.
Hi @fujitatomoya, could you rebase this to main branch? Then we should be able to merge it.
Signed-off-by: Tomoya.Fujita <[email protected]>
fujitatomoya
force-pushed
the
issue-109
branch
from
429b43d to
83e1ca1
Compare
|
@rsanchez15 done rebase against upstream/main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #109