Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inactive entities [15956] #177

Merged
merged 8 commits into from
Oct 26, 2022
Merged

Remove inactive entities [15956] #177

merged 8 commits into from
Oct 26, 2022

Conversation

jparisu
Copy link
Contributor

@jparisu jparisu commented Oct 14, 2022 •
edited
Loading

This was referenced Oct 17, 2022
Merged
Draft
@jparisu jparisu changed the title Remove inactive entities Remove inactive entities [15956] Oct 24, 2022
@jparisu jparisu force-pushed the feature/remove-inactive branch from 603f795 to b8deb06 Compare October 25, 2022 05:33
MiguelCompany
MiguelCompany requested changes Oct 25, 2022
View reviewed changes
MiguelCompany
MiguelCompany requested changes Oct 26, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit

@jparisu jparisu force-pushed the feature/remove-inactive branch from ca543d1 to 10cc72d Compare October 26, 2022 08:57
@jparisu jparisu temporarily deployed to codecov October 26, 2022 08:57 Inactive
@codecov
Copy link

codecov bot commented Oct 26, 2022 •
edited
Loading

Codecov Report

Base: 58.18% // Head: 58.42% // Increases project coverage by +0.24% 🎉

Coverage data is based on head (24c584b) compared to base (f0fde45).
Patch coverage: 64.17% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   58.18%   58.42%   +0.24%     
==========================================
  Files          33       33              
  Lines        4362     4421      +59     
  Branches     2320     2352      +32     
==========================================
+ Hits         2538     2583      +45     
+ Misses         57       54       -3     
- Partials     1767     1784      +17
Impacted Files Coverage Δ
src/cpp/database/database.hpp 64.70% <ø> (ø)
src/cpp/database/database.cpp 51.81% <61.90%> (+0.50%) ⬆️
src/cpp/StatisticsBackend.cpp 48.64% <100.00%> (+1.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jparisu jparisu temporarily deployed to codecov October 26, 2022 09:39 Inactive
MiguelCompany
MiguelCompany requested changes Oct 26, 2022
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit

@jparisu jparisu force-pushed the feature/remove-inactive branch from dfb9bcf to 2c2b020 Compare October 26, 2022 13:30
@jparisu jparisu temporarily deployed to codecov October 26, 2022 13:30 Inactive
Refs #15831: uncrustify
24c584b 
Signed-off-by: jparisu <[email protected]>
@jparisu jparisu temporarily deployed to codecov October 26, 2022 13:30 Inactive
@MiguelCompany MiguelCompany merged commit a61388a into main Oct 26, 2022
@MiguelCompany MiguelCompany deleted the feature/remove-inactive branch October 26, 2022 14:07
@JLBuenoLopez JLBuenoLopez mentioned this pull request Oct 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jparisu @MiguelCompany