Skip to content

Conversation

emiliocuestaf
Copy link
Contributor

This pull request introduces a notification system for alerts in the statistics backend, allowing users to associate external scripts with alert triggers.

Notifier Infrastructure

  • Added a new notifier system, including the Notifier, ScriptNotifier, and NotifierManager classes in Notifiers.hpp, enabling alerts to trigger external scripts asynchronously.
  • Included script validation and execution logic, supporting both Windows and Linux platforms.

Signed-off-by: Emilio Cuesta <[email protected]>
@Danipiza Danipiza self-requested a review October 15, 2025 06:41
@Danipiza Danipiza changed the title Add notifiers [#23719] Add notifiers Oct 15, 2025
Signed-off-by: Emilio Cuesta <[email protected]>
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 41.37931% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.05%. Comparing base (a580c10) to head (b4062bd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ude/fastdds_statistics_backend/types/Notifiers.hpp 47.50% 17 Missing and 4 partials ⚠️
src/cpp/database/database.cpp 27.58% 16 Missing and 5 partials ⚠️
src/cpp/StatisticsBackend.cpp 44.44% 2 Missing and 3 partials ⚠️
src/cpp/StatisticsBackendData.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
+ Coverage   46.72%   47.05%   +0.32%     
==========================================
  Files          53       54       +1     
  Lines       16993    17092      +99     
  Branches     7088     7129      +41     
==========================================
+ Hits         7940     8042     +102     
+ Misses       4547     4514      -33     
- Partials     4506     4536      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Emilio Cuesta <[email protected]>
Signed-off-by: Emilio Cuesta <[email protected]>
Co-authored-by: DannyP39 <[email protected]>
Signed-off-by: Emilio Cuesta Fernandez <[email protected]>
Co-authored-by: DannyP39 <[email protected]>
Signed-off-by: Emilio Cuesta Fernandez <[email protected]>
@Danipiza Danipiza merged commit f9022c0 into main Oct 16, 2025
17 of 18 checks passed
@Danipiza Danipiza deleted the feature/add-notifiers branch October 16, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants