Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lock_guard scope in DataWriterImpl::get_listener_for #4538

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MiguelCompany
Copy link
Member

Description

During the review of a backport of #4277, I discovered that this improvement could be made.

Opened the PR so I don't forget about the changes. Leaving as draft and with skip-ci till I create a task for it.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added the skip-ci Automatically pass CI label Mar 8, 2024
@JLBuenoLopez JLBuenoLopez force-pushed the 3.0.x-devel branch 2 times, most recently from 2de726b to 4a61143 Compare March 14, 2024 07:55
@EduPonz EduPonz force-pushed the 3.0.x-devel branch 3 times, most recently from c899270 to a0bdc0e Compare March 25, 2024 12:01
@EduPonz EduPonz force-pushed the 3.0.x-devel branch 3 times, most recently from 5148f5d to bd83bb2 Compare April 23, 2024 05:52
@EduPonz EduPonz force-pushed the 3.0.x-devel branch 2 times, most recently from 08ee62b to 623db82 Compare May 13, 2024 09:26
Base automatically changed from 3.0.x-devel to master May 14, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant