Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -Werror=template-id-cdtor (backport #5341) #5422

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 26, 2024

Description

solves error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x

Fixes #5340

Contributor Checklist

  • Commit messages follow the project guidelines.

  • N/A The code follows the style guidelines of this project.

  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A Any new/modified methods have been properly documented using Doxygen.

  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A New feature has been added to the versions.md file (if applicable).

  • N/A New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.
    This is an automatic backport of pull request Fix -Werror=template-id-cdtor #5341 done by Mergify.

@mergify mergify bot mentioned this pull request Nov 26, 2024
9 tasks
@MiguelCompany MiguelCompany added this to the v2.14.5 milestone Nov 26, 2024
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Dec 11, 2024
@MiguelCompany MiguelCompany self-requested a review December 11, 2024 12:42
@github-actions github-actions bot added the ci-pending PR which CI is running label Dec 11, 2024
@EugenioCollado EugenioCollado self-requested a review February 10, 2025 07:15
@EugenioCollado
Copy link
Contributor

@Mergifyio rebase

error: template-id not allowed for constructor in C++20 [-Werror=template-id-cdtor]
(cherry picked from commit 81f0069)
Copy link
Contributor Author

mergify bot commented Feb 10, 2025

rebase

✅ Branch has been successfully rebased

@EugenioCollado EugenioCollado force-pushed the mergify/bp/2.14.x/pr-5341 branch from 4f54e64 to 3a011d8 Compare February 10, 2025 07:18
@EugenioCollado EugenioCollado added ci-pending PR which CI is running and removed ci-pending PR which CI is running labels Feb 10, 2025
@EugenioCollado EugenioCollado requested review from EugenioCollado and removed request for EugenioCollado February 10, 2025 08:24
Copy link
Contributor

@EugenioCollado EugenioCollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EugenioCollado EugenioCollado added ci-pending PR which CI is running and removed ci-pending PR which CI is running labels Feb 10, 2025
@juanlofer-eprosima juanlofer-eprosima merged commit 74e3d6f into 2.14.x Feb 11, 2025
15 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the mergify/bp/2.14.x/pr-5341 branch February 11, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants