Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22735] Make the machine id the physical data host info #5592

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

juanjo4936
Copy link
Contributor

@juanjo4936 juanjo4936 commented Jan 22, 2025

This PR modifies the info that gets fed into the fastdds.physical_data host element, the machine_id instead of the host_id as it was before.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@juanjo4936 juanjo4936 added this to the v3.2.0 milestone Jan 22, 2025
@github-actions github-actions bot added the ci-pending PR which CI is running label Jan 22, 2025
@juanjo4936 juanjo4936 requested review from richiprosima and removed request for richiprosima January 22, 2025 14:58
@juanjo4936 juanjo4936 changed the title [22575]: Make the machine id the physical data host info [22735]: Make the machine id the physical data host info Feb 3, 2025
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Although I believe we should check if the machine-id is empty before using it to set the property, and fall back to the previous method in case it is empty. This might happens in certain docker environments.

Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima February 5, 2025 09:46
@cferreiragonz cferreiragonz changed the title [22735]: Make the machine id the physical data host info [22735] Make the machine id the physical data host info Feb 5, 2025
@cferreiragonz cferreiragonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Feb 6, 2025
@cferreiragonz cferreiragonz merged commit a29166f into master Feb 6, 2025
17 checks passed
@cferreiragonz cferreiragonz deleted the fix/finding-host branch February 6, 2025 06:30
RookieCLY pushed a commit to RookieCLY/Fast-DDS that referenced this pull request Feb 6, 2025
* Refs #22575: Make the machine id the physical data host info

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22735: Added reviwer suggestions

Signed-off-by: Juanjo Garcia <[email protected]>

---------

Signed-off-by: Juanjo Garcia <[email protected]>
Signed-off-by: RookieCLY <[email protected]>
RookieCLY pushed a commit to RookieCLY/Fast-DDS that referenced this pull request Feb 6, 2025
* Refs #22575: Make the machine id the physical data host info

Signed-off-by: Juanjo Garcia <[email protected]>

* Refs #22735: Added reviwer suggestions

Signed-off-by: Juanjo Garcia <[email protected]>

---------

Signed-off-by: Juanjo Garcia <[email protected]>
Signed-off-by: RookieCLY <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants