Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22721] Increase 'max_blocking_time' in Easy Mode #5617

Merged
merged 5 commits into from
Jan 31, 2025
Merged

[22721] Increase 'max_blocking_time' in Easy Mode #5617

merged 5 commits into from
Jan 31, 2025

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Jan 30, 2025 •
edited by MiguelCompany
Loading

Description

Adding a Discovery Server as central discovery point might introduce small delays in discovery in resource limited CPUs. When using services in ROS2, this might cause some of the server's responses to fail due to timeout. However, the max_blocking_time can be automatically increased for services in Easy Mode.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.2.0 milestone Jan 30, 2025
MiguelCompany
MiguelCompany requested changes Jan 30, 2025
View reviewed changes
@cferreiragonz cferreiragonz mentioned this pull request Jan 30, 2025
Merged
6 tasks
@cferreiragonz
Refs #22721: Review
69015da 
Signed-off-by: cferreiragonz <[email protected]>
@github-actions github-actions bot added the ci-pending PR which CI is running label Jan 30, 2025
@cferreiragonz cferreiragonz mentioned this pull request Jan 30, 2025
Merged
@cferreiragonz cferreiragonz force-pushed the increase_mbt_easy_mode branch from b94efd5 to d28aadf Compare January 30, 2025 15:08
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima January 30, 2025 15:08
MiguelCompany
MiguelCompany previously approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@cferreiragonz
Refs #22721: Fix Windows build
5cef70e 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz cferreiragonz force-pushed the increase_mbt_easy_mode branch from d28aadf to 5cef70e Compare January 31, 2025 07:10
MiguelCompany
MiguelCompany approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jan 31, 2025
@MiguelCompany MiguelCompany merged commit f9ec3a0 into master Jan 31, 2025
15 of 17 checks passed
@MiguelCompany MiguelCompany deleted the increase_mbt_easy_mode branch January 31, 2025 12:24
RookieCLY pushed a commit to RookieCLY/Fast-DDS that referenced this pull request Feb 6, 2025
@cferreiragonz @RookieCLY
Increase 'max_blocking_time' for services in Easy Mode (eProsima#5617)
b1aa00c 
* Refs #22721: Easy Mode XML Tests

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22721: Increase max_blocking_time in Easy Mode

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22721: Fix comments

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22721: Review

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22721: Fix Windows build

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: RookieCLY <[email protected]>
RookieCLY pushed a commit to RookieCLY/Fast-DDS that referenced this pull request Feb 6, 2025
@cferreiragonz @RookieCLY
Increase 'max_blocking_time' for services in Easy Mode (eProsima#5617)
42c2ebc 
* Refs #22721: Easy Mode XML Tests

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22721: Increase max_blocking_time in Easy Mode

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22721: Fix comments

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22721: Review

Signed-off-by: cferreiragonz <[email protected]>

* Refs #22721: Fix Windows build

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: RookieCLY <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cferreiragonz @MiguelCompany