Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22722] Support interfaces for RPC generated code #5622

Merged
merged 18 commits into from
Feb 10, 2025
Merged

[22722] Support interfaces for RPC generated code #5622

merged 18 commits into from
Feb 10, 2025

Conversation

MiguelCompany
Copy link
Member

Description

This adds the generic interfaces that the code generated by Fast DDS Gen for RPC interfaces will use.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany
Refs #22722. Add RpcException class.
bfa0826 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22722. Add RpcTimeoutException class.
576c2d4 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22722. Add RpcBrokenPipeException class.
404b75c
@MiguelCompany
Refs #22722. Add RpcOperationError class.
f95f09b 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22722. Add utility include for exceptions.
2fc5bdd 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22722. Add RpcServerReader template interface.
2183ead 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22722. Add RpcClientReader template interface.
e74cd0f 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22722. Add RpcServerWriter template interface.
78cd26c 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22722. Add RpcClientWriter template interface.
ee5fa7b 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22722. Add RpcInputFeedCancelledException.
f6672c4 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany
Refs #22722. Add RpcFuture template.
d8317a7 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany MiguelCompany changed the title [22722] Support interfaces for generated code [22722] Support interfaces for RPC generated code Jan 31, 2025
@MiguelCompany MiguelCompany added this to the v3.2.0 milestone Feb 4, 2025
mcheiva
mcheiva reviewed Feb 5, 2025
View reviewed changes
Copy link

@mcheiva mcheiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial EIVA review

@MiguelCompany
Copy link
Member Author

Initial EIVA review

@mcheiva I think I addressed all your comments. Could you re-review?

mcheiva
mcheiva approved these changes Feb 7, 2025
View reviewed changes
Copy link

@mcheiva mcheiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reviewed your answers to our comments, and it looks good! :)

@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Feb 10, 2025
@github-actions github-actions bot added the ci-pending PR which CI is running label Feb 10, 2025
@MiguelCompany MiguelCompany requested review from Carlosespicur and removed request for Carlosespicur February 10, 2025 09:22
@MiguelCompany MiguelCompany requested review from Carlosespicur and removed request for Carlosespicur February 10, 2025 10:55
@MiguelCompany MiguelCompany merged commit 56b9b72 into feature/rpc/main Feb 10, 2025
14 checks passed
@MiguelCompany MiguelCompany deleted the feature/22722 branch February 10, 2025 14:54
MiguelCompany added a commit that referenced this pull request Feb 12, 2025
@MiguelCompany
Support interfaces for RPC generated code (#5622)
723ae39 
* Refs #22722. Add RpcException class.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22722. Add RpcTimeoutException class.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22722. Add RpcBrokenPipeException class.

* Refs #22722. Add RpcOperationError class.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22722. Add utility include for exceptions.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22722. Add RpcServerReader template interface.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22722. Add RpcClientReader template interface.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22722. Add RpcServerWriter template interface.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22722. Add RpcClientWriter template interface.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22722. Add RpcInputFeedCancelledException.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22722. Add RpcFuture template.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22722. Rename `RpcInputFeedCancelledException` -> `RpcFeedCancelledException`

Signed-off-by: Miguel Company <[email protected]>

* Refs #22722. `RpcServerWriter` operations can throw `RpcFeedCancelledException`

Signed-off-by: Miguel Company <[email protected]>

* Refs #22722. Improve documentation of `RpcClientReader`

Signed-off-by: Miguel Company <[email protected]>

* Refs #22722. Improve documentation of `RpcClientWriter`

Signed-off-by: Miguel Company <[email protected]>

* Refs #22722. Avoid DSO export warning on Windows

Signed-off-by: Miguel Company <[email protected]>

* Refs #22722. Add utility include for interfaces.

Signed-off-by: Miguel Company <[email protected]>

* Refs #22722. Add missing argument on doxygen documentation.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carlosespicur Carlosespicur Carlosespicur approved these changes

@mcheiva mcheiva mcheiva approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @Carlosespicur @mcheiva