Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for DDS Examples: Configurability #5637

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

Yankefei
Copy link

@Yankefei Yankefei commented Feb 8, 2025

Description

In the example: In examples/cpp/ddds/Configurability/ConfigurabilityPublisher.cpp, I found that the variable no_keys has not been assigned a valid value and defaults to only 1, which will cause the following loop to only process once. According to the example code, multiple loops need to be executed based on the input user_configuration.no_keys.

image

After modification, subscribers can receive additional data:

pub:
img_v3_02ja_2241eb25-81ed-4955-b325-9f477e2bfb5g
sub:
knfyZHO8Os

@Mergifyio backport 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • [N/A] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [ N/A] Any new/modified methods have been properly documented using Doxygen.
  • [N/A ] Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • [N/A ] Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • [N/A ] Changes are API compatible.
  • [N/A ] New feature has been added to the versions.md file (if applicable).
  • [ N/A] New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • [ N/A] If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

MiguelCompany
MiguelCompany previously approved these changes Feb 10, 2025
@MiguelCompany MiguelCompany changed the base branch from 2.14.4 to 2.14.x February 10, 2025 07:08
@MiguelCompany MiguelCompany dismissed their stale review February 10, 2025 07:08

The base branch was changed.

@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Feb 10, 2025
@MiguelCompany MiguelCompany self-requested a review February 10, 2025 07:13
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green build

@Yankefei
Copy link
Author

@MiguelCompany Hi, I found that some sanitizers-ci tests are blocked. Is there anything else I need to do?

@MiguelCompany MiguelCompany added this to the v2.14.5 milestone Feb 14, 2025
@MiguelCompany
Copy link
Member

@MiguelCompany Hi, I found that some sanitizers-ci tests are blocked. Is there anything else I need to do?

Just ping me as you did! Thanks for your contribution!

@MiguelCompany MiguelCompany merged commit 2acdfa4 into eProsima:2.14.x Feb 14, 2025
15 checks passed
@Yankefei Yankefei deleted the 2.14.4_ykf_fix_example branch February 14, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants