[22604] Filter interested readers on PDP writer (backport #5604) #5657
+506
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Refs #22506. Regression test. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Add `PDPStatelessWriter` extending `StatelessWriter` Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Use `PDPStatelessWriter` in `SimplePDPEndpoints` Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Move specific API to `PDPStatelessWriter`. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Initial work on management of interested writers. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Take advantage of single sample history. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Reset state after sending datagram. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Filter interested readers. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Do not reset unsent changes upon participant discovery. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Fix AsymmeticIgnoreParticipantFlags test. Signed-off-by: Miguel Company <[email protected]> * Refs #22506. Create sender resources for matched readers. Signed-off-by: Miguel Company <[email protected]> * Refs #22708. Rename methods. Signed-off-by: Miguel Company <[email protected]> * Refs #22708. Avoid allocations using a `ResourceLimitedVector` instead of an `std::set` Signed-off-by: Miguel Company <[email protected]> * Refs #22604. Improve monitor service blackbox tests. Reducing announcement period to improve discovery timing. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 8eb1072)
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a high CPU and network usage situation with PDP simple discovery when a new participant is created in a network where there is a high number of existing participants.
@Mergifyio backport 3.1.x 3.0.x
An ABI compatible backport would be manually done to 2.14.x, and we will backport to other 2.x supported branches from there.
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the
versions.mdfile (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #5604 done by [Mergify](https://mergify.com).