feat: add cli option to enable serial hardware flow control #407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the CLI option
"-fc/--flow-control"to enable hardware flow control for serial and multiserial connections.The default behaviour is to have the hardware flow control disabled which is consistent with the current implementation. If the options
-fcor--flow-controlare provided then hardware flow control is enabled.Just like the baudrate setting, the flow control one is applied to all serial connections in multiserial mode.
The PR also fixes the
get_help()formatting, adding a missing new line character.Before the PR
After the PR
You can now run:
MicroXRCEAgent serial --dev /dev/ttyUSB0 -b 921600and observe that no flow control has been enabled:And you can run:
MicroXRCEAgent serial --dev /dev/ttyUSB0 -b 921600 -fcand observe that flow control has been enabled: