Skip to content

Commit

Permalink
Refs #20411: Do not expose output_file option
Browse files Browse the repository at this point in the history
Signed-off-by: EduPonz <[email protected]>
  • Loading branch information
EduPonz committed Feb 13, 2024
1 parent 090de47 commit 67e5225
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 23 deletions.
6 changes: 0 additions & 6 deletions multiplatform/junit_summary/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ inputs:
description: 'Path to directory containing XML files with the jUnit reports'
required: true

output_file:
description: 'Path to the file where the summary will be written'
required: true

print_summary:
description: 'Whether to print the summary (Default: True)'
required: false
Expand Down Expand Up @@ -39,7 +35,6 @@ runs:
uses: eProsima/eProsima-CI/ubuntu/junit_summary@feature/ctest2junit_translation
with:
junit_reports_dir: ${{ inputs.junit_reports_dir }}
output_file: ${{ inputs.output_file }}
print_summary: ${{ inputs.print_summary }}
show_failed: ${{ inputs.show_failed }}
show_disabled: ${{ inputs.show_disabled }}
Expand All @@ -50,7 +45,6 @@ runs:
uses: eProsima/eProsima-CI/windows/junit_summary@feature/ctest2junit_translation
with:
junit_reports_dir: ${{ inputs.junit_reports_dir }}
output_file: ${{ inputs.output_file }}
print_summary: ${{ inputs.print_summary }}
show_failed: ${{ inputs.show_failed }}
show_disabled: ${{ inputs.show_disabled }}
Expand Down
10 changes: 1 addition & 9 deletions ubuntu/junit_summary/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ inputs:
description: 'Path to directory containing XML files with the jUnit reports'
required: true

output_file:
description: 'Path to the file where the summary will be written'
required: true

print_summary:
description: 'Whether to print the summary (Default: True)'
required: false
Expand Down Expand Up @@ -37,11 +33,7 @@ runs:
id: junit_summary
shell: bash
run: |
OUTPUT_FILE_OPTION=""
if [[ ! -z "${{ inputs.output_file }}" ]]
then
OUTPUT_FILE_OPTION="--output-file ${{ inputs.output_file }}"
fi
OUTPUT_FILE_OPTION="--output-file $GITHUB_STEP_SUMMARY"
PRINT_SUMMARY_OPTION=""
if [[ "${{ inputs.print_summary }}" == "True" ]]
Expand Down
9 changes: 1 addition & 8 deletions windows/junit_summary/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ inputs:
description: 'Path to directory containing XML files with the jUnit reports'
required: true

output_file:
description: 'Path to the file where the summary will be written'
required: true

print_summary:
description: 'Whether to print the summary (Default: True)'
required: false
Expand Down Expand Up @@ -37,10 +33,7 @@ runs:
id: junit_summary
shell: pwsh
run: |
$OUTPUT_FILE_OPTION = ""
if (-not [string]::IsNullOrEmpty(${{ inputs.output_file }})) {
$OUTPUT_FILE_OPTION = "--output-file ${{ inputs.output_file }}"
}
$OUTPUT_FILE_OPTION = "--output-file $env:GITHUB_STEP_SUMMARY"
$PRINT_SUMMARY_OPTION = ""
if ($env:INPUT_PRINT_SUMMARY -eq "True") {
Expand Down

0 comments on commit 67e5225

Please sign in to comment.