Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20434] Use unique names for colcon_test uploaded artifacts #58

Closed
wants to merge 1 commit into from
Closed

[20434] Use unique names for colcon_test uploaded artifacts #58

wants to merge 1 commit into from

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Feb 14, 2024

Description

Contributor Checklist

  • Commit messages follow the company guidelines.
  • Changes are API compatible.
  • New features have been added to the versions.md and README.md files (if applicable).

Reviewer Checklist

  • The title and description correctly express the PR's purpose.
  • The Contributor checklist is correctly filled.

@EduPonz EduPonz marked this pull request as ready for review February 14, 2024 07:25
@EduPonz EduPonz force-pushed the hotfix/unique_names_colcon_test_artifacts branch 4 times, most recently from 87226b8 to 381789b Compare February 14, 2024 07:36
@EduPonz EduPonz force-pushed the hotfix/unique_names_colcon_test_artifacts branch from 381789b to 225462e Compare February 14, 2024 07:38
@EduPonz
Copy link
Author

EduPonz commented Feb 14, 2024

Closing this PR as the unique name can be passed from the caller

@EduPonz EduPonz closed this Feb 14, 2024
@EduPonz EduPonz deleted the hotfix/unique_names_colcon_test_artifacts branch February 14, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@EduPonz