change docker interface to newer docker image #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvkessel
reviewed
Apr 18, 2018
| @@ -6,13 +6,13 @@ | |||
|
|
|||
|
|
|||
| def elscata(settings: Settings): | |||
| with DockerContainer('elsepa', working_dir='/opt/elsepa') as elsepa: | |||
| with DockerContainer('elsepa', working_dir='/root') as elsepa: | |||
There was a problem hiding this comment.
When we merge the no-docker branch into master (I think there is no reason not to do this), this change becomes irrelevant.
| @@ -31,7 +31,7 @@ | |||
| 'Programming Language :: Python :: 3', | |||
| 'Topic :: Scientific/Engineering :: Physics'], | |||
| install_requires=[ | |||
| 'pint==0.8.1', 'numpy==1.13.0', 'docker==2.4.0', 'cslib', 'noodles[prov,numpy]==0.2.3'], | |||
| 'pint==0.8.1', 'numpy==1.13.0', 'docker==2.4.0', 'cslib', 'noodles'], | |||
There was a problem hiding this comment.
We deliberately pin version numbers for all packages. We have seen some developers introduce breaking API changes in minor updates (e.g. between an 1.1.0 and 1.1.1 release). We have also seen regressions introduced.
There was a problem hiding this comment.
very wise, then for the moment you should pin noodles to 0.3
There was a problem hiding this comment.
Seems that's not in pip yet. Nothing is broken at the moment (just weird output on windows), so we'll wait for the "proper" release. The installation procedure is horrible enough as it is :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the use of the docker interface to the docker image that is build using the Docker file in the project root.