Skip to content

Update2.0notebook2 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: update2.0
Choose a base branch
from
Open

Update2.0notebook2 #41

wants to merge 2 commits into from

Conversation

RolfHut
Copy link
Contributor

@RolfHut RolfHut commented Apr 19, 2025

just started, models not touched yet.

decisions to be made

  • wflow: which version? (Julia? Can we get parameter set?)
  • lisflood: continu support? show as legacy?
  • output: spatial plots or only time series? (pref: spatial plots)

many more.

RolfHut added 2 commits April 19, 2025 11:47
not touched model yet
not touched model yet
@RolfHut RolfHut self-assigned this Apr 19, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
Cell In[11], line 1
----> 1 observations['geo_y'].values[0]

IndexError: too many indices for array: array is 0-dimensional, but 1 were indexed

The value is a 0-d array. To get a python float do float(observations["geo_y"].values)

@BSchilperoort
Copy link
Member

  • Julia? Can we get parameter set?)

would be nice, yes.

  • lisflood: continu support? show as legacy?

That would be up to you. Supporting more models is more work, which should be balanced by how useful it is. Lisflood hasn't really had any users AFAIK so that doesn't help with debugging things either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants