Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.7 #766

Merged
merged 299 commits into from
Mar 11, 2024
Merged

Release 0.7 #766

merged 299 commits into from
Mar 11, 2024

Conversation

dapp-whisperer
Copy link
Contributor

@dapp-whisperer dapp-whisperer commented Jan 30, 2024

Release Candidate Changelog

Release 0.6 Changes

High Level Features

  • Simplified priceFeed, with governance over primary oracle. Hybrid solution uses the existing PriceFeed mechanics (which combines dual chainlink feeds with validity state machine + potential backup oracle) as the primary oracle in the new design.
  • Rounding issue scope verification and research project around potential rearchitectures
    • Practically mitigated by enforcing a 1000 wei minimum debt, and 1000 wei minimum change of debt. There is also a 1000 wei minimum change of collShares on user operations.
  • New TWAP on totalDebt to prevent spot manipulation of totalDebt via flashloan to reduce redemption fee scaling.
  • Governance work on timelock and configuration of highsec / lowsec timelocks.

PRs

Release 0.7 Changes

High Level Changes

  • CdpId's array was removed as it's sole purpose was to allow random access on-chain into list which was deemed not worth of storage.
  • Combined with switching liquidatorRewardShares to a uint128, it frees up a storage slot write on Cdp opens which is meaningful optimisation at low risk.
  • A new chainlink adapter combines the ETH/USD and BTC/USD feeds to get the ETH/BTC price, rather than using that feed directly.
  • The stETH:ETH rate is now read as a fixed 1:1 by default, rather than the market rate. There is a governance ability to switch the feed to the market rate oracle.

PRs

@ebtc-protocol ebtc-protocol deleted a comment from coderabbitai bot Feb 17, 2024
@ebtc-protocol ebtc-protocol deleted a comment from coderabbitai bot Feb 18, 2024
Copy link
Contributor

coderabbitai bot commented Feb 18, 2024

Warning

Rate Limit Exceeded

@dapp-whisperer has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 19 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 8843939 and 216d1dc.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

sajanrajdev and others added 2 commits February 23, 2024 17:20
@dapp-whisperer dapp-whisperer mentioned this pull request Mar 10, 2024
@dapp-whisperer dapp-whisperer merged commit 3406f0d into main Mar 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants