Skip to content

Conversation

@chunkitmax
Copy link
Contributor

@chunkitmax chunkitmax commented Jan 8, 2026

Note

  • Integration test (AWS KMS): Enable tz2 config and key import, then perform 5 transfer iterations for both tz2 and tz3 in vault_aws_test.go.
  • Dependencies: Bump versions in go.mod/go.sum (AWS SDK v2, GCP kms, Google APIs/genproto, logrus, x/net, etc.).
  • Azure vault: Use crypt.NewECDSASignature for ECDSA signature construction in pkg/vault/azure/azure.go.

Written by Cursor Bugbot for commit 468dba6. This will update automatically on new commits. Configure here.

@chunkitmax chunkitmax linked an issue Jan 8, 2026 that may be closed by this pull request
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 8, 2026

Deploying signatory with  Cloudflare Pages  Cloudflare Pages

Latest commit: 468dba6
Status: ✅  Deploy successful!
Preview URL: https://6f9147f5.signatory.pages.dev
Branch Preview URL: https://364-intermittent-invalid-sig.signatory.pages.dev

View logs

@chunkitmax chunkitmax force-pushed the 364-intermittent-invalid-signature-with-tz2-in-aws-kms branch from 63362f8 to 01c3c65 Compare January 8, 2026 20:40
@chunkitmax chunkitmax changed the title multiple iterations for transfer operations in integration tests multiple iterations for transfer operations with aws kms vault in integration tests Jan 13, 2026
@jevonearth jevonearth requested a review from e-asphyx January 13, 2026 18:55
@chunkitmax chunkitmax marked this pull request as ready for review January 13, 2026 18:59
@chunkitmax chunkitmax requested a review from GImbrailo January 15, 2026 22:50
Copy link
Contributor

@GImbrailo GImbrailo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GImbrailo GImbrailo merged commit 909a13e into main Jan 15, 2026
10 checks passed
@chunkitmax chunkitmax deleted the 364-intermittent-invalid-signature-with-tz2-in-aws-kms branch January 15, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

intermittent invalid signature with tz2 in aws kms

3 participants