Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add getters to ConfiguresProviders #145

Merged
merged 3 commits into from
Jan 25, 2025

Conversation

ChrisB-TL
Copy link
Contributor

A micro PR to add getters to ConfiguresProviders - for convenience where they have been dynamically set and you need to apply some logic based on the PendingRequest.

Copy link
Contributor

@sixlive sixlive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments/suggestions

src/Concerns/ConfiguresProviders.php Outdated Show resolved Hide resolved
src/Concerns/ConfiguresProviders.php Outdated Show resolved Hide resolved
tests/Text/PendingRequestTest.php Outdated Show resolved Hide resolved
@ChrisB-TL
Copy link
Contributor Author

@sixlive all make sense - thank you!

@sixlive sixlive changed the title Add getters to ConfiguresProviders feat: Add getters to ConfiguresProviders Jan 25, 2025
@sixlive sixlive merged commit 817ed8c into echolabsdev:main Jan 25, 2025
6 checks passed
@ChrisB-TL ChrisB-TL deleted the configures-providers-getters branch January 26, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants